Skip to content

Change sync to cp #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wagnerlmichael merged 1 commit into from
Oct 5, 2026
Merged

Change sync to cp #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/generate-homeval.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ jobs:
REMOTE="${REMOTE}/${YEAR}"
fi

aws s3 sync "${LOCAL}/" "${REMOTE}/" --no-progress
aws s3 cp "${LOCAL}/" "${REMOTE}/" --recursive --no-progress

@wagnerlmichael wagnerlmichael Oct 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With sync, the idea is to only upload what has changed, so it lists every object in the relevant s3 dir, then makes the comparison. I suspect this is why the upload takes so long.

cp just copies the file, and overwrites it if there is an existing file, which is orders of magnitude faster.

--recursive docs: --recursive (boolean) Command is performed on all files or objects under the specified directory or prefix.

I don't think that we need what sync provides, but maybe I'm missing something!


###############################################################################
# Invalidate cache and notify
Expand Down
Loading