Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade project to elm 0.19 #13

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Upgrade project to elm 0.19 #13

merged 1 commit into from
Sep 24, 2018

Conversation

andys8
Copy link
Contributor

@andys8 andys8 commented Sep 19, 2018

  • Updating package definition
  • Removing infix operators (unsupported)
  • Removing identity because intended for infix operators
  • Removing the use of (!)
  • Test is using elm/browser

Solves #12

@andys8
Upgrade project to elm 0.19
cd6aaf6 
* Updating package definition
* Removing infix operators (unsupported)
* Removing identity because intended for infix operators
* Removing the use of (!)
* Test is using elm/browser
@andys8
Copy link
Contributor Author

andys8 commented Sep 19, 2018

I am not sure about removing identity. The documentation said it is to be used with :> and the examples also made use of an operator for Maybe (?). If it makes sense, you can add it back in, and adapt the documentation.

@ccapndave
Copy link
Owner

Sorry for the delay! This looks great; I quickly searched through my code and I only use Update.identity in one place (by an infix) so I guess its ok.

@ccapndave ccapndave merged commit c7ab940 into ccapndave:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andys8 @ccapndave