Skip to content

Use the latest tk patch for a Mac issue (NO_JIRA) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 4, 2025
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:

- job: macOS
pool:
vmImage: "macOS-11"
vmImage: "macOS-13"
variables:
artifactory.platformName: "darwin"
steps:
Expand Down
35 changes: 18 additions & 17 deletions build_conquest_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ class ZlibPackage(InstallInConquestPythonBaseMixin, AutoconfMixin, NoArchiveMixi
@property
def source_archives(self):
return {
f'zlib-{self.version}.tar.xz': f'https://www.zlib.net/zlib-{self.version}.tar.xz'
# older version of zlib no longer available on zlib.net,
# so get it directly from Mark Adler's github repo
f'zlib-{self.version}.tar.xz': f'https://github.com/madler/zlib/releases/download/v{self.version}/zlib-{self.version}.tar.xz'
}


Expand Down Expand Up @@ -166,7 +168,7 @@ def verify(self):

class TclPackage(AutoconfMixin, NoArchiveMixin, Package):
name = 'tcl'
version = '8.6.11'
version = '8.6.16'
tclversion = '8.6'

@property
Expand All @@ -179,17 +181,15 @@ def source_archives(self):
def extract_source_archives(self):
super().extract_source_archives()
# Remove packages we don't want to build
shutil.rmtree(self.main_source_directory_path /
'pkgs' / 'sqlite3.34.0')
shutil.rmtree(self.main_source_directory_path / 'pkgs' / 'tdbc1.1.2')
shutil.rmtree(self.main_source_directory_path /
'pkgs' / 'tdbcmysql1.1.2')
shutil.rmtree(self.main_source_directory_path /
'pkgs' / 'tdbcodbc1.1.2')
shutil.rmtree(self.main_source_directory_path /
'pkgs' / 'tdbcpostgres1.1.2')
shutil.rmtree(self.main_source_directory_path /
'pkgs' / 'tdbcsqlite3-1.1.2')
sp = Path(self.main_source_directory_path / 'pkgs')

sqlite_path = sp.glob('sqlite*')
for file in sqlite_path:
shutil.rmtree(file)

tbc_path = sp.glob('tdbc*')
for file in tbc_path:
shutil.rmtree(file)

@property
def main_source_directory_path(self):
Expand Down Expand Up @@ -297,14 +297,15 @@ def verify(self):

class TkPackage(AutoconfMixin, NoArchiveMixin, Package):
name = 'tk'
version = '8.6.11'
version = '8.6.16'

@property
def source_archives(self):
return {
# Canonical would be https://prdownloads.sourceforge.net/tcl/ but it's fetching garbage
# How lovely to have a different tcl and tk version....
f'tk{self.version}-src.tar.gz': f'https://freefr.dl.sourceforge.net/project/tcl/Tcl/{self.version}/tk{self.version}.1-src.tar.gz'
# The url is a bit of a mess, but it's the only one that works?
f'tk{self.version}-src.tar.gz': f'https://sourceforge.net/projects/tcl/files/Tcl/{self.version}/tk{self.version}-src.tar.gz/download'
}

@property
Expand Down Expand Up @@ -506,12 +507,12 @@ def arguments_to_configuration_script(self):

class JpegPackage(InstallInConquestPythonBaseMixin, AutoconfMixin, NoArchiveMixin, Package):
name = 'jpeg'
version = '9e'
version = '9f'

@property
def source_archives(self):
return {
f'jpegsrc.v{self.version}.tar.gz': f'https://fossies.org/linux/misc/jpegsrc.v9e.tar.gz'
f'jpegsrc.v{self.version}.tar.gz': f'https://fossies.org/linux/misc/jpegsrc.v{self.version}.tar.gz'
}


Expand Down
37 changes: 19 additions & 18 deletions common-tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,25 @@ steps:
scriptPath: build_conquest_python.py
displayName: 'install conquest_python'

# Upload artifactory build info
- task: ArtifactoryCollectIssues@1
inputs:
artifactoryService: 'devops-ccdc-3rd-party'
configSource: 'taskConfiguration'
taskConfig: |
version: 1
issues:
trackerName: JIRA
regexp: '(.*?)\b\(?(Jira|JIRA|jira)?\s+([A-Za-z]{2,5}\d*-\d+)\)?'
keyGroupIndex: 3
summaryGroupIndex: 1
trackerUrl: https://jira.ccdc.cam.ac.uk/issues
aggregate: true
aggregationStatus: RELEASED
buildName: '$(Build.DefinitionName)'
buildNumber: '$(Build.BuildNumber)-$(artifactory.platformName)'
displayName: 'Collect issues'
#### The new artifactory doesn't support sorting, so we can't do this task for now
## Upload artifactory build info
#- task: ArtifactoryCollectIssues@1
# inputs:
# artifactoryService: 'devops-ccdc-3rd-party'
# configSource: 'taskConfiguration'
# taskConfig: |
# version: 1
# issues:
# trackerName: JIRA
# regexp: '(.*?)\b\(?(Jira|JIRA|jira)?\s+([A-Za-z]{2,5}\d*-\d+)\)?'
# keyGroupIndex: 3
# summaryGroupIndex: 1
# trackerUrl: https://jira.ccdc.cam.ac.uk/issues
# aggregate: true
# aggregationStatus: RELEASED
# buildName: '$(Build.DefinitionName)'
# buildNumber: '$(Build.BuildNumber)-$(artifactory.platformName)'
# displayName: 'Collect issues'

- powershell: |
$filename = Get-ChildItem -Path $(Build.ArtifactStagingDirectory) -Filter *.tar.gz | Select-Object -ExpandProperty Name
Expand Down