Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sdks v1.0 #31

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open

Conversation

Kabangi
Copy link
Contributor

@Kabangi Kabangi commented Jun 14, 2017

  • Fixes an issue with getMembers on channel always returning undefined.

  • Implement getUserDescriptor and getAndSubscribeUser on android

svlaev and others added 30 commits May 4, 2017 13:01
* master:
  Android bug fixes (ccm-innovation#19)
  Send message with attributes (ccm-innovation#17)
(forgot to stash those changes in the last commit)
* master:
  Update to React Native 0.40 (ccm-innovation#8)
  a few typos referencing IPMessaging. See ccm-innovation#20. (ccm-innovation#21)
  Update Twilio SDKs (0.17.1/0.12.1) (ccm-innovation#11)

# Conflicts:
#	Example/ios/Podfile
#	Example/package.json
#	android/build.gradle
* master:
  added benoist to contributers
  version 0.3.1
  added reference to Yoga in exampe podfile
  Fix compile on iOS (ccm-innovation#22)

# Conflicts:
#	.gitignore
@Kabangi
Copy link
Contributor Author

Kabangi commented Sep 16, 2017

@zachrnolan I would really love to hear your experience with twilio-chat

@svlaev
Copy link
Contributor

svlaev commented Sep 18, 2017

@Kabangi I also have experience with twilio-chat. The app is still in development. So far so good. I had some problems with the push notifications. I wrote to the Twilio ppl and they fixed the issue in the latest JS SDK. Haven't checked if pushes work yet, but I believe they should.
Twilio even released an example app with RN integration to help us.
If you have any issues - write them. They are always open for feedback.
Good luck!

@zachrnolan
Copy link

@Kabangi It's working great so far. I'm not using push notifications, so not sure about that. I'm planning on writing a blog post soon about integrating it with RN. I'll keep you updated.

@marneborn
Copy link

marneborn commented Sep 18, 2017 via email

@svlaev
Copy link
Contributor

svlaev commented Sep 18, 2017

@marneborn IIRC it happened on version 1.0.4. I was passing the push token to the sdk, but when I tried to send a push, I got "Invalid credential SID" error in the twilio console debugger. Versions > 1.1.0 should work fine.
P.S. Keep an eye on the changelog here: https://www.twilio.com/docs/api/chat/changelogs/javascript

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants