Skip to content

Conversation

DmitryMK
Copy link
Collaborator

@DmitryMK DmitryMK commented Oct 8, 2025

Addresses #1366
It is build on top of #1365, which should be merged (or rejected) first.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the application's exit code handling to return exit code 2 for error conditions instead of 0, addressing issue #1366. This ensures proper error reporting to external systems that depend on exit codes.

  • Changed application exit codes from 0 to 2 for various error conditions
  • Added exclude rules functionality with new --exclude-rules CLI option
  • Added validation to prevent simultaneous use of include and exclude rules

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
core.py Added exclude-rules CLI option and updated exit codes to 2 for error conditions
cdisc_rules_engine/models/validation_args.py Added exclude_rules field to validation args model
scripts/script_utils.py Enhanced rule loading functions to support exclude rules and updated error handling
tests/unit/test_script_utils.py Added comprehensive tests for new exclude rules functionality
tests/unit/test_services/test_data_service/test_data_service.py Updated test data to include additional None parameter
tests/QARegressionTests/test_core/test_validate.py Added tests for exclude rules and updated expected exit codes
README.md Updated documentation to include new exclude-rules option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DmitryMK
Copy link
Collaborator Author

Reverted the change introduced by #1351 for the -vx flag (--validate-xml).

@RamilCDISC
Copy link
Collaborator

Could you please resolve the conflicts on this ticket ? and then we are good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants