-
Notifications
You must be signed in to change notification settings - Fork 22
1366 update exit code #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1366 update exit code #1369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the application's exit code handling to return exit code 2 for error conditions instead of 0, addressing issue #1366. This ensures proper error reporting to external systems that depend on exit codes.
- Changed application exit codes from 0 to 2 for various error conditions
- Added exclude rules functionality with new
--exclude-rules
CLI option - Added validation to prevent simultaneous use of include and exclude rules
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
core.py | Added exclude-rules CLI option and updated exit codes to 2 for error conditions |
cdisc_rules_engine/models/validation_args.py | Added exclude_rules field to validation args model |
scripts/script_utils.py | Enhanced rule loading functions to support exclude rules and updated error handling |
tests/unit/test_script_utils.py | Added comprehensive tests for new exclude rules functionality |
tests/unit/test_services/test_data_service/test_data_service.py | Updated test data to include additional None parameter |
tests/QARegressionTests/test_core/test_validate.py | Added tests for exclude rules and updated expected exit codes |
README.md | Updated documentation to include new exclude-rules option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reverted the change introduced by #1351 for the -vx flag (--validate-xml). |
Could you please resolve the conflicts on this ticket ? and then we are good to merge. |
Addresses #1366
It is build on top of #1365, which should be merged (or rejected) first.