-
Notifications
You must be signed in to change notification settings - Fork 22
1333: sync requirements.txt and pyproject.toml #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexfurmenkov
wants to merge
11
commits into
main
Choose a base branch
from
1333-sync-pyproject.toml-and-requirements.txt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
76614fb
sync requirements.txt and pyproject.toml
alexfurmenkov e657f35
extract dev dependencies into requirements-dev.txt
alexfurmenkov b8b5d3e
extract dev dependencies into requirements-dev.txt
alexfurmenkov dd6fa50
extract dev dependencies into requirements-dev.txt
alexfurmenkov 8cfa012
install dependencies from requirements-dev.txt in the lint pipeline
alexfurmenkov 74dbd7e
install dependencies from requirements-dev.txt in the lint pipeline
alexfurmenkov d706710
install dependencies from requirements-dev.txt in the lint pipeline
alexfurmenkov c804f1b
update README.md
alexfurmenkov 290df47
update README.md
alexfurmenkov 3fde8af
add -r requirements.txt to dev requirements
alexfurmenkov 9de92a9
add -r requirements.txt to dev requirements
alexfurmenkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ In the terminal, navigate to the directory you intend to install CORE rules engi | |
|
||
This project uses the `black` code formatter, `flake8` linter for python and `prettier` for JSON, YAML and MD. | ||
It also uses `pre-commit` to run `black`, `flake8` and `prettier` when you commit. | ||
Both dependencies are added to _requirements.txt_. | ||
Both dependencies are added to _requirements-dev.txt_. | ||
|
||
**Required** | ||
|
||
|
@@ -103,6 +103,8 @@ NOTE: if you have multiple versions of python on your machine, you can call pyth | |
|
||
`python -m pip install -r requirements.txt` # From the root directory | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. eliminate this line-- just need to install python -m pip install -r requirements-dev.txt |
||
|
||
`python -m pip install -r requirements-dev.txt` # From the root directory (this will install dev dependencies like black, flake8, pytest etc.) | ||
|
||
### **Running The Tests** | ||
|
||
From the root of the project run the following command (this will run both the unit and regression tests): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,34 +4,12 @@ build-backend = "setuptools.build_meta" | |
|
||
[project] | ||
name = "cdisc-rules-engine" | ||
dynamic = ["version"] | ||
dynamic = ["version", "dependencies"] | ||
description = "Open source offering of the cdisc rules engine" | ||
readme = "PYPI.md" | ||
requires-python = ">=3.12, <3.13" | ||
license = { text = "MIT" } | ||
authors = [{ name = "cdisc-org", email = "[email protected]" }] | ||
dependencies = [ | ||
"business_rules_enhanced==1.4.8", | ||
"cdisc-library-client==0.1.6", | ||
"importlib-metadata==8.5.0", | ||
"jsonpath-ng==1.6.1", | ||
"jsonschema==4.18.5", | ||
"numpy~=1.23.2", | ||
"odmlib==0.1.4", | ||
"openpyxl==3.1.5", | ||
"pandas==1.5.2", | ||
"python-dotenv==0.20.0", | ||
"pyyaml==6.0.2", | ||
"redis==4.0.2", | ||
"requests~=2.32.3", | ||
"cachetools==6.1.0", | ||
"Pympler==1.1", | ||
"psutil==6.1.1", | ||
"pyreadstat==1.2.7", | ||
"fastparquet==2024.2.0", | ||
"dask[dataframe]==2024.2.0", | ||
"dask[array]==2024.2.0", | ||
] | ||
|
||
[project.urls] | ||
"Homepage" = "https://github.com/cdisc-org/cdisc-rules-engine" | ||
|
@@ -49,3 +27,4 @@ py-modules = ["version"] | |
|
||
[tool.setuptools.dynamic] | ||
version = { attr = "version.__version__" } | ||
dependencies = {file = ["requirements.txt"]} |
alexfurmenkov marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
-r requirements.txt | ||
black==24.10.0 | ||
flake8==6.1.0 | ||
pre-commit==2.20.0 | ||
pytest==7.4.0 | ||
pytest-asyncio==0.21.0 | ||
pytest-cov==6.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only needs the requirements-dev.txt if we reference requirements.txt in the dev file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry not getting your point... we basically need to install dev dependencies here to make pytest work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is in reference to what i wrote below:
"I would add a line -r requirement.txt to this file at the top so users can install all requirements for dev and runtime with just pip install requirement-dev.txt"
If installing dev requirements has a reference to requirement.txt, then we only need
pip install -r requirements-dev.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, just updated