Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeUtils: do not pass stdin to group upcalls #581

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

martinetd
Copy link
Collaborator

Some commands consume stdin when they shouldn't, but we shouldn't have been giving stdin to upcalls in the first place.

Reported-by: Kilian Cavalotti [email protected]

replaces #580

Some commands consume stdin when they shouldn't, but we shouldn't have
been giving stdin to upcalls in the first place.

Reported-by: Kilian Cavalotti <[email protected]>
Copy link
Collaborator

@degremont degremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a line in the right place in documentation to clarify that?

Otherwise, LGTM!

@martinetd
Copy link
Collaborator Author

Hmm, documentation doesn't seem to say much about how upcalls are executed currently, I think it's fine as it is.

Group source upcalls in doc/sphinx/config.rst could perhaps say something (e.g. "upcalls' standard output is used if the command returns 0, standard input is closed and standard error is shared with the caller"), especially the part about requiring success execution now that I noticed it, I don't know.

@degremont
Copy link
Collaborator

Actually you're right, this is not that important.

@thiell thiell added this pull request to the merge queue Feb 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 23, 2025
@thiell thiell added this pull request to the merge queue Feb 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 23, 2025
@thiell thiell merged commit 129d6ed into cea-hpc:master Feb 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants