completion: handle short opts without spaces #586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using clush -c we should try to complete local files. When not using -c, if a taget has already been set we can also try to complete a command. We could do like ssh and try to complete it on any node in the nodeset, but a local completion is probably good enough. And still complete possible options but only do so if a dash was present, this is similar to what e.g. `ls` completion does Fixes cea-hpc#584
Apparently some people want to use clush -wfoo...
martinetd
force-pushed
the
completions_shortopt_nospace
branch
from
f2e7399 to
5f93494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently some people want to use clush -wfoo...
(Since it's a different issue than #585 this is open as a different PR, I don't like the merge queue squashing unrelated commits :p Note it should be merged after #585 as I've left the other commit in for easier testing, but there's no conflict so we could rebase if required. Opened as draft because of this.)