Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add options to forget command #27

Merged
merged 1 commit into from
Mar 11, 2025
Merged

add options to forget command #27

merged 1 commit into from
Mar 11, 2025

Conversation

cyrilst
Copy link
Contributor

@cyrilst cyrilst commented Feb 25, 2025

  • Necessary step to be able to later add sshproxyctl forget persistent_connection or something like that
  • forget host, enable and disable have been changed to use the same syntax: -all|-host HOST [-port PORT]
  • Also kinda neat to be able to sshproxyctl disable -all when starting a big maintenance

@cyrilst cyrilst self-assigned this Feb 25, 2025
@cyrilst cyrilst force-pushed the forget branch 4 times, most recently from e380381 to 2f2d5ed Compare March 4, 2025 08:35
od-cea
od-cea reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@od-cea od-cea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR with documentation and new options.
A typo and may be some small improvements ?

@cyrilst cyrilst force-pushed the forget branch 6 times, most recently from be191d5 to 674e722 Compare March 11, 2025 12:24
@cyrilst cyrilst merged commit a49296b into master Mar 11, 2025
6 checks passed
@cyrilst cyrilst deleted the forget branch March 11, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@od-cea od-cea od-cea left review comments

@t-valette t-valette Awaiting requested review from t-valette

@fdiakh fdiakh Awaiting requested review from fdiakh

Assignees

@cyrilst cyrilst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrilst @od-cea