Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convert command to sshproxyctl #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add convert command to sshproxyctl #35

wants to merge 1 commit into from

Conversation

cyrilst
Copy link
Contributor

@cyrilst cyrilst commented Mar 13, 2025

  • The hack made for unmarshaling durations was not needed since about 10 years. I removed it and cleaned a bit the code.
  • No need to add a test in docker, as configv1_test.go tests the functionality from end to end (input file to output text)

@cyrilst cyrilst self-assigned this Mar 13, 2025
@cyrilst cyrilst marked this pull request as ready for review March 13, 2025 15:32
@cyrilst cyrilst requested review from t-valette, fdiakh and od-cea March 13, 2025 15:33
Copy link

github-actions bot commented Mar 20, 2025

File Coverage
All files 6%
cmd/sshproxy-dumpd/sshproxy-dumpd.go 0%
cmd/sshproxy-replay/sshproxy-replay.go 0%
cmd/sshproxy/commands.go 0%
cmd/sshproxy/recorder.go 0%
cmd/sshproxy/sshproxy.go 0%
cmd/sshproxyctl/sshproxyctl.go 0%
pkg/nodesets/nodesets.go 0%
pkg/record/record.go 0%
pkg/utils/config.go 0%
pkg/utils/configv1.go 100%
pkg/utils/etcd.go 0%
pkg/utils/logging.go 0%
pkg/utils/route.go 0%
pkg/utils/utils.go 92%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against e138678

@cyrilst cyrilst changed the title add migrate command to sshproxyctl add convert command to sshproxyctl Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant