Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for config.go and resolve a few config bugs #36

Draft
wants to merge 1 commit into
base: migrate
Choose a base branch
from

Conversation

cyrilst
Copy link
Contributor

@cyrilst cyrilst commented Mar 21, 2025

I love tests. These ones discovered a few bugs:

  • in etcd and ssh subconfigs, overrides would crash sshproxy at config load
  • overrides of intervals did not properly check if the interval values are strings before parsing them
  • LoadAllDestsFromConfig did not expand destination nodesets

Copy link

github-actions bot commented Mar 21, 2025

File Coverage
All files 16%
cmd/sshproxy-dumpd/sshproxy-dumpd.go 0%
cmd/sshproxy-replay/sshproxy-replay.go 0%
cmd/sshproxy/commands.go 0%
cmd/sshproxy/recorder.go 0%
cmd/sshproxy/sshproxy.go 0%
cmd/sshproxyctl/sshproxyctl.go 0%
pkg/nodesets/nodesets.go 0%
pkg/record/record.go 0%
pkg/utils/config.go 100%
pkg/utils/configv1.go 100%
pkg/utils/etcd.go 0%
pkg/utils/logging.go 0%
pkg/utils/route.go 9%
pkg/utils/utils.go 92%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 7798ce8

@cyrilst cyrilst force-pushed the tests branch 2 times, most recently from 1dbe26b to 2e33c9f Compare March 25, 2025 09:31
@cyrilst cyrilst force-pushed the migrate branch 2 times, most recently from 1db3ac9 to e138678 Compare March 31, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant