Conversation
|
Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95) ❓ No new benchmark data submitted. ❓ |
Pull Request Test Coverage Report for Build 12889454238Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
GagaLP
left a comment
There was a problem hiding this comment.
LGTM! Is now working out of the Box with DPCPP, nice :)
PeterTh
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for taking care of this, nice to be back to green on nightlies.
479eec2 to
a9697ef
Compare
|
Check-perf-impact results: (deac89ab3c981780086a8f2d08cf6170) ❓ No new benchmark data submitted. ❓ |
|
Check-perf-impact results: (cad5fb03670f51e00b16688b9ca8eaf9) ✔️ No significant performance change in the microbenchmark set. You are good to go! Relative execution time per category: (mean of relative medians)
|








Required to build with recent DPC++.
Recent spdlog inspects
CMAKE_CXX_STANDARD, so we need to set this variable. I'm removingCELERITY_CXX_STANDARDin favor of this global setting, and automatically re-apply it infind_package(Celerity)unless the user has requested a higher standard themselves.