Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fmt and spdlog dependencies #328

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Bump fmt and spdlog dependencies #328

merged 4 commits into from
Jan 21, 2025

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Jan 14, 2025

Required to build with recent DPC++.

Recent spdlog inspects CMAKE_CXX_STANDARD, so we need to set this variable. I'm removing CELERITY_CXX_STANDARD in favor of this global setting, and automatically re-apply it in find_package(Celerity) unless the user has requested a higher standard themselves.

@fknorr fknorr requested a review from psalz January 14, 2025 15:22
@fknorr fknorr self-assigned this Jan 14, 2025
@fknorr fknorr requested review from PeterTh and GagaLP January 14, 2025 15:22
Copy link

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12889454238

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.104%

Totals Coverage Status
Change from base Build 12789820097: 0.0%
Covered Lines: 7084
Relevant Lines: 7189

💛 - Coveralls

@fknorr
Copy link
Contributor Author

fknorr commented Jan 14, 2025

Passes the nightly build now!

image

Copy link
Contributor

@GagaLP GagaLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is now working out of the Box with DPCPP, nice :)

Copy link
Contributor

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for taking care of this, nice to be back to green on nightlies.

Copy link

Check-perf-impact results: (deac89ab3c981780086a8f2d08cf6170)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

Copy link

Check-perf-impact results: (cad5fb03670f51e00b16688b9ca8eaf9)

✔️ No significant performance change in the microbenchmark set. You are good to go!

Relative execution time per category: (mean of relative medians)

  • command-graph : 1.00x
  • graph-nodes : 1.02x
  • grid : 0.99x
  • instruction-graph : 1.00x
  • scheduler : 1.00x
  • system : 1.04x
  • task-graph : 1.00x

@fknorr fknorr merged commit ca02d38 into master Jan 21, 2025
13 checks passed
@fknorr fknorr deleted the bump-fmt-spdlog branch January 21, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants