-
Notifications
You must be signed in to change notification settings - Fork 331
Change wording from L1 to L2 #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Change wording from L1 to L2 #1735
Conversation
✅ Deploy Preview for celo-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
History.md and from-ethereum.md needs to be checked as the changes are deeper. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- These changes should not be merged before the migration happens on 26th March UTC: https://x.com/Celo/status/1896617306509500661
- Without the warnings, some of the content becomes more confusing post-L2 migration: eg on
docs/developer/migrate/from-ethereum.md
, the section about the Celo native token will be wrong since it'll no longer live on the Celo-L2 chain but on Ethereum and be bridged to L2.
I would recommend doing a more in-depth rewrite of these pages.
Celo is an Ethereum L2, let's make that clear on the docs
1d77ad3
to
1fc12b9
Compare
Delete things that apparently weren't remove on the Git rebase
…to-indicate-were-already-an-L2
@atejada I can do another round of review if you can fix the PR :) |
Replaced a link that doesn't exist anymore
Forgot to update this broken link
@lvpeschke PR is fixed 😁 I'm not sure how much it makes to merge these, as there have been a lot of changes already.anyways, please review it and maybe we can merge it after all 😄 |
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
@@ -5,15 +5,7 @@ description: Overview of the similarities and differences between the Celo and E | |||
|
|||
# Celo for Ethereum Developers | |||
|
|||
Overview of the similarities and differences between the Celo and Ethereum blockchains. | |||
|
|||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep the warning, as the rest of the page would need to be rewritten to accurately reflect Celo now.
docs/general/history.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now at https://docs.celo.org/what-is-celo/history, please merge any relevant pieces into that page.
@@ -7,13 +7,6 @@ description: How to get a preconfigured Celo blockchain node running on one of t | |||
|
|||
How to get a preconfigured Celo blockchain node running on one of the major cloud providers. | |||
|
|||
:::warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still relevant, the page needs rewriting.
@@ -7,13 +7,6 @@ description: How to run a full node on the Celo Mainnet Network using a prebuilt | |||
|
|||
How to run on the Mainnet Network using a prebuilt Docker image. | |||
|
|||
:::warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still relevant, the page needs rewriting.
@@ -3,18 +3,10 @@ title: Celo Randomness | |||
description: How unpredictable pseudo-randomness is achieved on the Celo blockchain. | |||
--- | |||
|
|||
:::warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still relevant, randomness has been removed.
@@ -22,38 +19,26 @@ Be sure you understand and review the risks when bridging assets between chains. | |||
|
|||
::: | |||
|
|||
## Bridges To and From Celo | |||
## Bridging To and From Celo | |||
|
|||
### Popular Bridges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are ther removals here?
- [Superbridge Celo Mainnet](https://superbridge.app/celo) | ||
- [Superbridge Alfajores Testnet](https://testnets.superbridge.app/celo-alfajores) | ||
- [Superbridge Baklava Testnet](https://testnets.superbridge.app/celo-baklava) | ||
|
||
## Cross-Chain Messaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
Co-authored-by: Victoria <[email protected]>
Co-authored-by: Victoria <[email protected]>
Celo is an Ethereum L2, let's make that clear on the docs