Skip to content

Change wording from L1 to L2 #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Mar 11, 2025

Celo is an Ethereum L2, let's make that clear on the docs

@atejada atejada requested review from a team as code owners March 11, 2025 04:08
@atejada atejada requested a review from jcortejoso March 11, 2025 04:08
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for celo-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8425329
🔍 Latest deploy log https://app.netlify.com/sites/celo-docs/deploys/68010015019d4f00084a97f9
😎 Deploy Preview https://deploy-preview-1735--celo-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 39 (🟢 up 12 from production)
Accessibility: 92 (no change from production)
Best Practices: 67 (no change from production)
SEO: 76 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@atejada
Copy link
Contributor Author

atejada commented Mar 11, 2025

History.md and from-ethereum.md needs to be checked as the changes are deeper.

Copy link
Contributor

@lvpeschke lvpeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • These changes should not be merged before the migration happens on 26th March UTC: https://x.com/Celo/status/1896617306509500661
  • Without the warnings, some of the content becomes more confusing post-L2 migration: eg on docs/developer/migrate/from-ethereum.md, the section about the Celo native token will be wrong since it'll no longer live on the Celo-L2 chain but on Ethereum and be bridged to L2.

I would recommend doing a more in-depth rewrite of these pages.

Celo is an Ethereum L2, let's make that clear on the docs
@atejada atejada force-pushed the Update-L2-language-to-indicate-were-already-an-L2 branch from 1d77ad3 to 1fc12b9 Compare March 25, 2025 14:16
@lvpeschke
Copy link
Contributor

@atejada I can do another round of review if you can fix the PR :)

atejada added 3 commits April 8, 2025 11:02
Replaced a link that doesn't exist anymore
Forgot to update this broken link
@atejada
Copy link
Contributor Author

atejada commented Apr 8, 2025

@lvpeschke PR is fixed 😁 I'm not sure how much it makes to merge these, as there have been a lot of changes already.anyways, please review it and maybe we can merge it after all 😄

.idea/.gitignore Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

@@ -5,15 +5,7 @@ description: Overview of the similarities and differences between the Celo and E

# Celo for Ethereum Developers

Overview of the similarities and differences between the Celo and Ethereum blockchains.

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the warning, as the rest of the page would need to be rewritten to accurately reflect Celo now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now at https://docs.celo.org/what-is-celo/history, please merge any relevant pieces into that page.

@@ -7,13 +7,6 @@ description: How to get a preconfigured Celo blockchain node running on one of t

How to get a preconfigured Celo blockchain node running on one of the major cloud providers.

:::warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still relevant, the page needs rewriting.

@@ -7,13 +7,6 @@ description: How to run a full node on the Celo Mainnet Network using a prebuilt

How to run on the Mainnet Network using a prebuilt Docker image.

:::warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still relevant, the page needs rewriting.

@@ -3,18 +3,10 @@ title: Celo Randomness
description: How unpredictable pseudo-randomness is achieved on the Celo blockchain.
---

:::warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still relevant, randomness has been removed.

@@ -22,38 +19,26 @@ Be sure you understand and review the risks when bridging assets between chains.

:::

## Bridges To and From Celo
## Bridging To and From Celo

### Popular Bridges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are ther removals here?

- [Superbridge Celo Mainnet](https://superbridge.app/celo)
- [Superbridge Alfajores Testnet](https://testnets.superbridge.app/celo-alfajores)
- [Superbridge Baklava Testnet](https://testnets.superbridge.app/celo-baklava)

## Cross-Chain Messaging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

@lvpeschke lvpeschke removed request for a team and jcortejoso April 17, 2025 13:19
atejada and others added 2 commits April 17, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants