Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTOR-1394-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-handle-step-metrics-when-scenario-failed #5461

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

CTOR-1394-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-handle-step-metrics-when-scenario-failed #5461

wants to merge 2 commits into from

Conversation

Evan-Adam
Copy link
Contributor

@Evan-Adam Evan-Adam commented Feb 24, 2025 •
edited
Loading

Description

  • Change the default status for 0 / 3 / 4 / 5 / 6 / 7 to unknown
  • don't show perfdata for step if the step was not executed on the last execution of the scenario
    • previously the last successfull execution of the step was taken into account, this is not the case anymore.

Fixes # CTOR-1394

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

See automated tests

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@Evan-Adam Evan-Adam force-pushed the CTOR-1394-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-handle-step-metrics-when-scenario-failed branch from 4719d5e to b6c67d9 Compare February 24, 2025 13:46
@Evan-Adam Evan-Adam marked this pull request as ready for review February 24, 2025 13:46
@Evan-Adam Evan-Adam requested review from a team as code owners February 24, 2025 13:46
lucie-dubrunfaut
lucie-dubrunfaut reviewed Feb 25, 2025
View reviewed changes
src/apps/monitoring/iplabel/ekara/restapi/mode/scenarios.pm Outdated
foreach my $step_metrics (@{$scenario_detail->{results}}) {
if ($step_metrics->{planningTime} ne $last_execution){
$self->{output}->add_option_msg(long_msg => "Execution $step_metrics->{planningTime} of step $step_metrics->{stepId} is older than $last_execution, not taking it into account.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that it's better in a debug output rather than in long output?

@Evan-Adam Evan-Adam force-pushed the CTOR-1394-plugin-apps-monitoring-iplabel-ekara-restapi-mode-scenarios-handle-step-metrics-when-scenario-failed branch from b6c67d9 to 1b7b8d7 Compare February 25, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucie-dubrunfaut lucie-dubrunfaut lucie-dubrunfaut left review comments

@bouda1 bouda1 Awaiting requested review from bouda1 bouda1 is a code owner automatically assigned from centreon/owners-robot-e2e

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-robot-e2e

@sdepassio sdepassio Awaiting requested review from sdepassio sdepassio is a code owner automatically assigned from centreon/owners-perl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-workflow-plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evan-Adam @lucie-dubrunfaut