Skip to content

fix(search): restore working fetch and escape query param against XSS #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RAJVEER42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(search): restore working fetch and escape query param against XSS #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/js/search-output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,23 @@ const SearchOutput = {
const urlParams = new URLSearchParams(queryString);
const query = urlParams.get('q');

function escapeHtml(str) {
return str
.replace(/&/g, '&')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#39;');
}

async function initSearchIndex() {
if (!urlParams.has('q')) return;

try {
searchInput.value = query;

const [searchIndex, searchOutput] = await Promise.all(
searchDataUrls.map(url =>
fetch(url, {
method: 'GET',
credentials: 'include',
mode: 'no-cors',
}).then(res => res.json())
)
searchDataUrls.map(url => fetch(url).then(res => res.json()))
);
const lunrIndex = lunr.Index.load(searchIndex);

Expand Down Expand Up @@ -68,10 +71,12 @@ const SearchOutput = {

if (!searchresultsContainer) return;

const safeQuery = escapeHtml(query);

if (!results.length) {
searchResultsHtml = `<p class="h3 mb-8 xl:mb-10">${noResultsString} “${query}”</p>`;
searchResultsHtml = `<p class=”h3 mb-8 xl:mb-10”>${noResultsString} “${safeQuery}”</p>`;
} else {
searchResultsHtml = `<p class="h3 mb-8 xl:mb-10">${searchedForString} “${query}”</p>
searchResultsHtml = `<p class=”h3 mb-8 xl:mb-10”>${searchedForString} “${safeQuery}”</p>
<ul class="grid md:grid--cols-2 lg:grid--cols-3 xl:grid--cols-4 list-none m-0 p-0">${results
.map(({ author, content, date, image, title, url }) => {
const restucturedData = {
Expand Down