-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/#171 카테고리 API 수정 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Fix/#171 카테고리 API 수정 #172
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2754125
#164 [fix] 계열별/직무별 자격증 Top3 조회 구현
woals2840 85f0d76
#164 [fix] 자격증 조회 수정
woals2840 faf0d2a
[hotfix] docker hub 계정 변경
seongmin0229 f354cf1
[hotfix] docker hub 계정 변경
seongmin0229 9de7f45
#164 [fix] 계열별/직무별 자격증 Top3 조회 구현
woals2840 55eb838
#164 [fix] 자격증 조회 수정
woals2840 becfb70
Merge remote-tracking branch 'origin/fix/#164' into fix/#164
seongmin0229 c08a34a
#164 [fix] 코드래빗 반영
woals2840 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,5 +42,5 @@ jobs: | |
| context: . | ||
| file: ./Dockerfile | ||
| push: true | ||
| tags: woals2840/certi-server | ||
| tags: seongmin0229/certi-server | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...va/org/sopt/certi_server/domain/certification/dto/response/CertificationRankResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package org.sopt.certi_server.domain.certification.dto.response; | ||
|
|
||
| import org.sopt.certi_server.domain.certification.entity.Certification; | ||
|
|
||
| public record CertificationRankResponse( | ||
| int rank, | ||
| String certificationName, | ||
| String certificationType | ||
| ) { | ||
| public CertificationRankResponse(int rank, Certification certification) { | ||
| this( | ||
| rank, | ||
| certification.getName(), | ||
| certification.getCertificationType() != null | ||
| ? certification.getCertificationType().getKoreanName() | ||
| : null | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: cerdeuk/CERTI-BE
Length of output: 124
🏁 Script executed:
Repository: cerdeuk/CERTI-BE
Length of output: 725
🏁 Script executed:
rg -A 10 "TrackType.*track" src/main/java/org/sopt/certi_server/domain/user/entity/User.javaRepository: cerdeuk/CERTI-BE
Length of output: 737
🏁 Script executed:
rg "findTopCertificationsByTrack" src/main/java/org/sopt/certi_server/domain/certification/repository/Repository: cerdeuk/CERTI-BE
Length of output: 42
🏁 Script executed:
Repository: cerdeuk/CERTI-BE
Length of output: 3137
🏁 Script executed:
rg "private TrackType track" -A 5 -B 2 src/main/java/org/sopt/certi_server/domain/user/entity/User.javaRepository: cerdeuk/CERTI-BE
Length of output: 253
🏁 Script executed:
rg "findTopCertifications" src/main/java/ --type javaRepository: cerdeuk/CERTI-BE
Length of output: 405
🏁 Script executed:
rg "getUser" src/main/java/org/sopt/certi_server/domain/user/service/UserService.java -A 10Repository: cerdeuk/CERTI-BE
Length of output: 1473
🏁 Script executed:
Repository: cerdeuk/CERTI-BE
Length of output: 224
🏁 Script executed:
Repository: cerdeuk/CERTI-BE
Length of output: 2065
트랙 타입이 null인 경우 쿼리가 올바르게 작동하지 않습니다
User 엔티티의
track필드는nullable=false제약이 없어 null이 될 수 있습니다.user.getTrack()이 null을 반환하면 이를 그대로 저장소 메서드에 전달하는데, 쿼리의where u.track = :track조건에서 null 값과의 비교로 인해 예상치 못한 결과가 반환됩니다. SQL에서NULL = NULL은 false이므로 해당 사용자의 인증들이 조회되지 않습니다.trackType이 null인 경우를 처리하거나, 사용자의 track이 반드시 존재해야 한다면 명시적으로 검증하세요.
🤖 Prompt for AI Agents