-
Notifications
You must be signed in to change notification settings - Fork 5
feat(form): improve collection fields #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miguelgrc
wants to merge
1
commit into
cern-sis:master
Choose a base branch
from
miguelgrc:improve-collections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d322722
to
31ca5eb
Compare
pamfilos
requested changes
May 27, 2025
src/forms/templates/ArrayFieldTemplates/AccordionArrayFieldTemplate.jsx
Outdated
Show resolved
Hide resolved
_uiPath = [...uiSchemaPath, "items"]; | ||
schema.items = schema.items || {}; | ||
|
||
if (Object.keys(schema.items).length === 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to test better (on me)
31ca5eb
to
492bd58
Compare
pamfilos
reviewed
May 30, 2025
bordered={false} | ||
style={{ whiteSpace: "normal", height: "auto", marginTop: 5 }} | ||
> | ||
{(!!rawHelp && help) || (!!rawErrors && renderFieldErrors())} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was changed in the last commit 2471f1c#diff-ba073726ca75570133ed6237e95ad5ea1e39c53d0c3b61083dc85ace4fc3a011R103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
Improvements for collection fields, new collapsible setting and some other (mostly visual) changes
Functional changes:
Layer
andAccordion
fields now work out of the box (no need to add them inside arrays)collapsible
common setting (for all fields). When enabled the field will be collapsed and only the title will be displayed until expanded.items
field inside array/layer/accordion as it was causing issues with the uiSchema updates. It didn't make a lot of sense to have this option anyway.Visual changes: