Skip to content

Conversation

@cdce8p cdce8p requested a review from a team as a code owner September 19, 2025 11:48
@cdce8p cdce8p requested a review from ohemorange September 19, 2025 11:48
@ohemorange
Copy link
Contributor

am I missing something in the black changelog? I don't see a note about it supporting 3.14

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 22, 2025

am I missing something in the black changelog? I don't see a note about it supporting 3.14

Seems it was added as part of psf/black#4720. Note that it isn't necessary that black supports all (new) features of 3.14 just yet as those can't be used until 3.13 is dropped anyway.

All that was necessary is that py314 is now an allowed value for black.

@ohemorange
Copy link
Contributor

I see. Looks like when they officially announced 3.13 support, they tested it in various places first. https://github.com/psf/black/pull/4436/files That has not yet been done for 3.14, so I'd say black 3.14 support is still incidental and unofficial. Personally, I would prefer to wait until they announce stable support for 3.14.

@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 23, 2025

Personally, I would prefer to wait until they announce stable support for 3.14.

Not sure it really matters in the context of this PR. It's still years until we'd be able to use Template strings here for example. Technically, all that's really needed with target-version often times is to specified the lowest supported version.

Anyway, there is also the option to get rid of it completely if we adopt poetry-core v2 which supports project.requires-python. Opened #242 for that. Let me know what you think.

@ohemorange
Copy link
Contributor

I like that plan. Looks like #242 got auto-assigned, I moved it to my queue and will take a look but at first glance I like that approach.

@ohemorange ohemorange requested a review from bmw September 25, 2025 21:51
@ohemorange ohemorange assigned bmw and unassigned ohemorange Sep 25, 2025
Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bmw bmw merged commit 79050d8 into certbot:main Sep 25, 2025
9 checks passed
@cdce8p cdce8p deleted the update-pre-commit branch September 25, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants