-
Notifications
You must be signed in to change notification settings - Fork 30
Update pre-commit versions #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
am I missing something in the black changelog? I don't see a note about it supporting 3.14 |
Seems it was added as part of psf/black#4720. Note that it isn't necessary that black supports all (new) features of 3.14 just yet as those can't be used until 3.13 is dropped anyway. All that was necessary is that |
|
I see. Looks like when they officially announced 3.13 support, they tested it in various places first. https://github.com/psf/black/pull/4436/files That has not yet been done for 3.14, so I'd say black 3.14 support is still incidental and unofficial. Personally, I would prefer to wait until they announce stable support for 3.14. |
Not sure it really matters in the context of this PR. It's still years until we'd be able to use Template strings here for example. Technically, all that's really needed with Anyway, there is also the option to get rid of it completely if we adopt poetry-core |
|
I like that plan. Looks like #242 got auto-assigned, I moved it to my queue and will take a look but at first glance I like that approach. |
bmw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
https://black.readthedocs.io/en/stable/change_log.html#id1
https://flake8.pycqa.org/en/latest/release-notes/7.1.2.html
https://flake8.pycqa.org/en/latest/release-notes/7.2.0.html
https://flake8.pycqa.org/en/latest/release-notes/7.3.0.html
https://github.com/PyCQA/isort/releases/tag/6.0.0
https://github.com/PyCQA/isort/releases/tag/6.0.1