Remote sites became redundant with Winter'19

[rsoesemann]

With Winter'19 remote site setting for Metadata API calls from Apex are not needed anymore https://releasenotes.docs.salesforce.com/en-us/winter19/release-notes/rn_apex_streamline_api_calls.htm

I just replace the URL creation code. Someone also might want to remove the Remote site helper files.

[afawcett]

Thanks for this @rsoesemann, looks good. We should update the docs a bit more to say that in most cases you are now correct, thankfully not needed! However for orgs without my domain enabled its still needed, hopefully this will become more of a corner case as time goes by though. 👍

[afawcett]

Anyway, this change looks good to me! 👍 cc @stephenwillcock @agarciaodeian

[rsoesemann]

I was a bit shocked today that this is still not merged in.

[jakubmplatek]

It seems that URL.getSalesforceBaseUrl().toExternalForm() works without the RSS as well
Are they planning to deprecate it in favour of getOrgDomainUrl() ?

[rsoesemann]

@jakubmplatek Can't confirm what you are saying. I used the current state of the repo yesterday and it still fail due to a missing RSS. Only when I changed to the new getOrgDomainUrl() it worked. Or do you mean switching version number is sufficient.

[jakubmplatek]

I think I updated my service class to 45, so that might be it. I can't check it now, but can test it again on Tuesday and let you know.

…

On Sat, May 25, 2019, 08:50 Robert Sösemann ***@***.***> wrote: @jakubmplatek <https://github.com/jakubmplatek> Can't confirm what you are saying. I used the current state of the repo yesterday and it still fail due to a missing RSS. Only when I changed to the new getOrgDomainUrl() it worked. Or do you mean switching version number is sufficient. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#224>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENAWCO6O7XZFWSEVNMDDZDPXFN4RANCNFSM4F6NCTVQ> .