Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-value security fix #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

set-value security fix #28

wants to merge 3 commits into from

Conversation

bergren2
Copy link
Member

@bergren2 bergren2 commented Apr 12, 2020

  • bump Webpack so we're working with similar dependencies down the road
  • upgrade Snapdragon as a dependency so it's using a patched version of set-value
  • bump Webpack CLI so the builds work again

@bergren2
Copy link
Member Author

Okay, this has been an open issue for years: nickmerwin/node-coveralls#80

Noticed a Microsoft team (microsoft/vscode-python#6340) focused on making sure the builds still passed even if sending to Coveralls failed, and then eventually switched to Codecov. Another option is to switch off of Travis CI. I'd advocate for a similar approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant