Remove the tag command

- This was never actually used in production in any way
- I think we should move to using OCI artifacts to store builds
  and there's already a natural tag representation there
- This code is Python and I am trying to push to using Go

Author: cgwalters

cmd/coreos-assembler.go

@@ -15,7 +15,7 @@ import (
 var buildCommands = []string{"init", "fetch", "build", "run", "prune", "clean", "list"}
 var advancedBuildCommands = []string{"buildfetch", "buildupload", "oc-adm-release", "push-container", "upload-oscontainer", "buildextend-extensions"}
 var buildextendCommands = []string{"aliyun", "aws", "azure", "digitalocean", "exoscale", "gcp", "ibmcloud", "kubevirt", "live", "metal", "metal4k", "nutanix", "openstack", "qemu", "secex", "virtualbox", "vmware", "vultr"}
-var utilityCommands = []string{"aws-replicate", "build-extensions-container", "compress", "generate-hashlist", "koji-upload", "kola", "push-container-manifest", "remote-build-container", "remote-prune", "remote-session", "sign", "tag", "update-variant"}
+var utilityCommands = []string{"aws-replicate", "build-extensions-container", "compress", "generate-hashlist", "koji-upload", "kola", "push-container-manifest", "remote-build-container", "remote-prune", "remote-session", "sign", "update-variant"}
 var otherCommands = []string{"shell", "meta"}
 
 func init() {

src/cmd-build

@@ -29,7 +29,6 @@ Usage: coreos-assembler build --help
   --skip-prune        Skip prunning previous builds
   -F | --fetch        Also perform a fetch
   --strict            Only allow installing locked packages when using lockfiles
-  --tag TAG           Set the given tag in the build metadata
   --version VERSION   Use the given version instead of generating one based on current time
 
   Additional environment variables supported:
@@ -49,10 +48,9 @@ SKIP_PRUNE=0
 VERSION=
 PARENT=
 PARENT_BUILD=
-TAG=
 STRICT=
 rc=0
-options=$(getopt --options hfFt: --longoptions tag:,help,fetch,force,version:,parent:,parent-build:,delay-meta-merge,force-nocache,force-image,skip-prune,strict -- "$@") || rc=$?
+options=$(getopt --options hfFt: --longoptions help,fetch,force,version:,parent:,parent-build:,delay-meta-merge,force-nocache,force-image,skip-prune,strict -- "$@") || rc=$?
 [ $rc -eq 0 ] || {
     print_help
     exit 1
@@ -95,10 +93,6 @@ while true; do
             shift
             PARENT_BUILD=$1
             ;;
-        -t | --tag)
-            shift
-            TAG=$1
-            ;;
         --)
             shift
             break
@@ -542,11 +536,5 @@ else
 fi
 rm builds/.build-commit
 
-if [ -n "${TAG}" ]; then
-    # ideally, we'd do this atomically before moving to builds/latest, but
-    # meh... not much can go wrong with `cosa tag`
-    /usr/lib/coreos-assembler/cmd-tag update --build "${buildid}" --tag "${TAG}"
-fi
-
 # and finally, build the specified targets
 build_followup_targets