Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort a bunch of lines and remove duplicates #447

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Sort a bunch of lines and remove duplicates #447

merged 2 commits into from
Jan 22, 2025

Conversation

mattlorimor
Copy link
Contributor

No description provided.

tstromberg
tstromberg approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Just a fair warning: different sort implementations and environmental values will result in different sort orders. For example, GNU sort vs BSD sort.

@mattlorimor
Copy link
Contributor Author

mattlorimor commented Jan 22, 2025 •
edited
Loading

+1. Just a fair warning: different sort implementations and environmental values will result in different sort orders. For example, GNU sort vs BSD sort.

Yeah. Ideally we'd agree upon (have we already and I just didn't see the command?) the tool to run to do the sorting/formatting for the SQL and it'd run on local make or fmt or something instead of me being silly and doing it with an editor.

@mattlorimor mattlorimor merged commit 19dab18 into main Jan 22, 2025
3 checks passed
@mattlorimor mattlorimor deleted the lorimor/SortAndRemoveDupes branch January 22, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@egibs egibs egibs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattlorimor @tstromberg @egibs