Fix issue 1811 #2123
Closed
Fix issue 1811 #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file defines a single macro that attempts to autoconfigure chakracore.
The Shared Library for ChakraCore already contains all symbols needed. This means that most applications will only need symbols that are exported by libChakraCore.so or libChakraCore.dylib.
This file is intended to be under MIT license.
This provides a solution to issue chakra-core#1811, but this also breaks the ch utility in the process.
|
Hi @kphillisjr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
There is no reason for xplat to have this function be non-reentrant. This also reduces the number of code changes in issue chakra-core#1811 since this change fixes the issue with running ch.
kphillisjr
force-pushed
the
fix_issue_1811
branch
from
494c5af to
fe3dcfe
Compare
kphillisjr
commented
Nov 30, 2016
| @@ -296,7 +296,7 @@ char16 const * DynamicProfileStorage::GetMessageType() | |||
|
|
|||
| bool DynamicProfileStorage::Initialize() | |||
| { | |||
| AssertMsg(!initialized, "Initialize called multiple times"); | |||
There was a problem hiding this comment.
This change was supposed to be an definition check against _WIN32. For xplat this function is safe to call repeatedly.
|
Resubmitted as pull request #2124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the changes required to fix issue #1811. There is only two changes and this ensures that ch runs correctly after on Linux/OSX.
Also, this pull request is branched off of another pull request ( see: #2111 )