Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/models/scvi docs adjustments #1319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tools/models/scvi docs adjustments #1319

wants to merge 2 commits into from

Conversation

mlin
Copy link
Contributor

@mlin mlin commented Nov 25, 2024

A few minor updates to the scvi docs; mainly, I hit weird ImportErrors without using a clean virtualenv.

@mlin mlin requested review from ebezzi and ivirshup November 25, 2024 08:44
Copy link
Collaborator

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but generally looks good. Would like @ebezzi to take a look before merging though.

Any chance you have the traceback from those ImportErrors?

tools/models/scvi/scvi-init.sh Outdated Show resolved Hide resolved
@mlin
Copy link
Contributor Author

mlin commented Nov 25, 2024

@ivirshup I found one in my notes, ImportError: cannot import name 'html5lib' from 'pip._vendor'. I presume it was something to do with using a different python version than shipped with ubuntu 20.04, but I didn't look too closely once I found it worked in the virtualenv.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (f32c274) to head (c05adc8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files          82       82           
  Lines        6482     6482           
=======================================
  Hits         5922     5922           
  Misses        560      560           
Flag Coverage Δ
unittests 91.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants