Skip to content

Conversation

@OresteMarquis
Copy link
Collaborator

Description

In the time-harmonic Maxwell solver, when using the waveguide inlet boundary and defining a left-handed basis of vector by the 4 points creating the quadrilateral of the mesh the resulting computed excitation field was wrong.

Solution

Instead of only flipping the two basis vector (which led to erroneous calculation), we perform all the computation in the local reference and apply a rotation matrix to revert the solution to the global reference frame.

Testing

This has been tested by the unit test the unit tests have been updated to test this new orientation.

Documentation

No new documentation.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@OresteMarquis OresteMarquis added the WIP When a PR is open but not ready for review label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP When a PR is open but not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant