Update waveguide inlet boundary #1897
Open
+94
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the time-harmonic Maxwell solver, when using the waveguide inlet boundary and defining a left-handed basis of vector by the 4 points creating the quadrilateral of the mesh the resulting computed excitation field was wrong.
Solution
Instead of only flipping the two basis vector (which led to erroneous calculation), we perform all the computation in the local reference and apply a rotation matrix to revert the solution to the global reference frame.
Testing
This has been tested by the unit test the unit tests have been updated to test this new orientation.
Documentation
No new documentation.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: