Skip to content

Conversation

@brunaccampos
Copy link
Collaborator

@brunaccampos brunaccampos commented Feb 5, 2026

Description

The same mapping object was being used at every multigrid level which, when the mortar feature is enabled, led to incorrect setup of mapping within level operators. This PR fixes this, as well as some other minor typos/descriptions.

Solution

A MappingQCache object is now created at every level when set enable = true in the mortar subsection.

Testing

No new tests were added. This issue was only spotted in larger simulations, which is why existing application tests were not affected.

Documentation

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • Fix has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@brunaccampos brunaccampos marked this pull request as ready for review February 6, 2026 00:22
@brunaccampos brunaccampos added Bug Something isn't working Ready for review Needs more reviewers This pull request needs more review before a merge is possible labels Feb 6, 2026
@brunaccampos brunaccampos requested a review from peterrum February 6, 2026 00:23
@blaisb blaisb merged commit 3d19fdb into master Feb 6, 2026
10 checks passed
@blaisb blaisb deleted the mortar_fix_multigrid_mapping branch February 6, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Needs more reviewers This pull request needs more review before a merge is possible Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants