Skip to content

Conversation

@brunaccampos
Copy link
Collaborator

@brunaccampos brunaccampos commented Feb 6, 2026

Description

This PR reverts the changes made in #1887 except the documentation of functions.

Testing

Documentation

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@brunaccampos brunaccampos added the Refactoring This PR is only refactoring or clean up label Feb 6, 2026
@blaisb
Copy link
Contributor

blaisb commented Feb 6, 2026

Looks good from my side @brunaccampos :). I will just not squash and merge it

@brunaccampos
Copy link
Collaborator Author

Looks good from my side @brunaccampos :). I will just not squash and merge it

I think actually you can do squash and merge it; if later we want to go back and re-revert this, we would bring back only the changes of tests to prototypes (meaning that this PR is not connected anymore to the previous one #1887), no? I haven't done this before so whatever you think works best!

@brunaccampos brunaccampos marked this pull request as ready for review February 6, 2026 20:09
@blaisb blaisb merged commit 4218f56 into master Feb 6, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for review Refactoring This PR is only refactoring or clean up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants