Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config param to avoid Python exception checking overheads #26573

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Jan 21, 2025

Adds Python.checkExceptions (on by default), which allows users to turn off the exception checking to avoid overhead.

This PR also includes a few other cleanups and adds a future for #26579

  • start_test test/library/packages/Python
  • start_test test/library/packages/Python --compopts -scheckExceptions=false
    • this has 1 expected failure of argPassingTest, which tests exceptions

Future work:

  • It would be nice to support this as a per-interpreter param as well, but that opens us up to issues with generics and classes. So for now thats a todo/nice-to-have

[Reviewed by @DanilaFe]

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 requested a review from DanilaFe January 21, 2025 23:01
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 merged commit 506b25e into chapel-lang:main Jan 23, 2025
8 checks passed
@jabraham17 jabraham17 deleted the add-checkException-param branch January 23, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants