Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dupe import #73

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: dupe import #73

merged 1 commit into from
Dec 26, 2024

Conversation

zachvalenta
Copy link
Contributor

When I was building the project locally I spotted a compiler warning: get_file_color is already imported

Removed this (seemingly) dupe import, rebuilt, and then called the new binary (./target/debug/lla) and everything worked as I'd expect it to.

This is my first time working with Rust, so apologies in advance for any mistakes/misunderstandings!

Also, noticed that you're using conventional commits (feat, refactor, fix, docs). Are these tags defined anywhere in the docs?

Copy link
Owner

@chaqchase chaqchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zachvalenta for the fix, looks good!

Yes indeed I'm using the conventional commits in the project they're not documented in the documentation of the project but you can read more about them here https://www.conventionalcommits.org/en/v1.0.0/

And thanks again for taking the time

@chaqchase chaqchase merged commit 9b0cfd0 into chaqchase:main Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants