fix(permissions): swallow SPACE in dialog to prevent stray approval - #3567
Closed
Ricardo-M-L wants to merge 1 commit into
Closed
fix(permissions): swallow SPACE in dialog to prevent stray approval#3567Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
Closes charmbracelet#2799. When the user is typing in the chat editor and a permissions dialog opens, an in-flight SPACE keystroke could be delivered to the dialog. The viewport's default `KeyMap.PageDown` binding includes "space"; the dialog disables that binding via `key.NewBinding(key.WithDisabled())`, so SPACE doesn't currently *approve*, but the experience is still surprising — depending on focus/timing the keystroke can still cause the dialog to react. Add an explicit early return for SPACE in the dialog's KeyPressMsg handler, before any other matching. The dialog now requires an explicit Enter / a / s / d / mouse click to act, matching what the issue requests.
Ricardo-M-L
changed the title
Contributor
Author
|
Superseded by clean rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses: fix(permissions): swallow SPACE in dialog to prevent stray approval