feat: add docs for how to deploy the filesystem client #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
force-pushed
the
how-to-deploy-shared-filesystem
branch
7 times, most recently
from
6acd2c1 to
757f924
Compare
|
I think this is on a good enough state for review. |
jedel1043
force-pushed
the
how-to-deploy-shared-filesystem
branch
from
757f924 to
7cd70b7
Compare
AshleyCliff
requested changes
Jan 24, 2025
Comment on lines
196
to
197
| To add the charm that takes care of mounting a shared filesystem to the cluster nodes, | ||
| deploy the `filesystem-client` charm: |
There was a problem hiding this comment.
Suggested change
| To add the charm that takes care of mounting a shared filesystem to the cluster nodes, | |
| deploy the `filesystem-client` charm: | |
| To add the `filesystem-client` charm, which mounts a shared filesystem to the cluster nodes: |
jedel1043
force-pushed
the
how-to-deploy-shared-filesystem
branch
from
7cd70b7 to
36faade
Compare
jedel1043
force-pushed
the
how-to-deploy-shared-filesystem
branch
2 times, most recently
from
6a6a55c to
ad4e220
Compare
AshleyCliff
requested changes
Jan 28, 2025
Comment on lines
31
to
35
| - Amazon Web Services | ||
| - See [Create an NFS file share using the default configuration][aws-nfs] for general set up information. | ||
| - Azure | ||
| - See [Tutorial: Create an NFS Azure file share and mount it on a Linux VM using the Azure portal][azure-nfs] | ||
| for general set up information. |
There was a problem hiding this comment.
This could probably be formatted more cleanly but I'm not quite sure what that would look like - I'll think about it
There was a problem hiding this comment.
Made some adjustments to use clickable cards instead of a bullet list. Let me know if this looks better!
There was a problem hiding this comment.
I like the cards! I might see if we can tweak the background color so they stand out a bit more (darn dark mode), but they're functional as is.
jedel1043
force-pushed
the
how-to-deploy-shared-filesystem
branch
from
ad4e220 to
4cf536d
Compare
jedel1043
force-pushed
the
how-to-deploy-shared-filesystem
branch
from
4cf536d to
c11a41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.