Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation for deploying Slurm #19

Merged

Conversation

NucciTheBoss
Copy link
Member

This PR updates the Slurm documentation to be more current, and adds instructions for deploying Slurm with both the CLI and Terraform. Also includes additional sections for how to set the node state to idle and verify that they are idle.

Other things this PR does is enable to attrs_inline and colon_fence MyST extensions so we can get more cool and awesome MyST features.

Related issues

Enabled these extension so that we can have both in-line syntax highlighting for code, and colon blocks to more easily show that we are working with MyST, not just markdown with extra steps.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss requested a review from a team as a code owner January 17, 2025 15:43
@NucciTheBoss NucciTheBoss requested review from AshleyCliff and removed request for a team January 17, 2025 15:43
Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and a few grammar edits, but overall looks good.

Now include instructions for using Terraform as well.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Rename done to make it clear what HPC infrastructure we're working with rather than just being generic. Too premature to optimize for a possible future where we're supporting multiple workload managers.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
New words added:

* hostname
* sackd
* juju
* Terraform/terraform

Signed-off-by: Jason C. Nucciarone <[email protected]>
`myst-parser` discourages using implicit targets for referencing headers.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Changes:

* Move note about ingress to Prerequisites section since it's VERY IMPORTANT (Grafana Agent won't work without it), and update admonition to be more specific about what happens if ingress is not enabled.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss force-pushed the nuccitheboss/docs/update-deploy-wlm branch from bcab09d to 5d601e3 Compare January 21, 2025 19:29
@NucciTheBoss
Copy link
Member Author

@AshleyCliff ready for another review. Having the same linkcheck issue as #18. Seems to be an intermittent problem with the jwt website.

Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, especially the change to Grafan Agent as a proper noun and then general readability in that section. Added a comment to the Juju Terraform discussion and a note about inline code highlighting.

More consistent nomenclature between CLI and Terraform. Also indicates the existence of multiple clients for integrating with Charmed HPC.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss
Copy link
Member Author

Ready for round 3 😎

Linkcheck still seems to be freaking out however 😢

Uses the annotation `{l=shell}` to highlight commands intended to be run through the shell.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss
Copy link
Member Author

NucciTheBoss commented Jan 22, 2025

Fixed linkcheck failures by simply ignoring "https://jwt.io"

@AshleyCliff
Copy link
Contributor

Looks great!

@AshleyCliff AshleyCliff merged commit 315cd31 into charmed-hpc:main Jan 22, 2025
2 checks passed
@NucciTheBoss NucciTheBoss deleted the nuccitheboss/docs/update-deploy-wlm branch January 31, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add howto section for marking compute nodes active after deployment
2 participants