docs(rdma): initial interconnects Explanation and Reference sections #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsloanm
requested review from
AshleyCliff and
a team
and removed request for
a team
AshleyCliff
requested changes
Feb 4, 2025
reference/interconnects/index.md
Outdated
| :header: > | ||
| : cloud, interconnect, instance availability, subnet management, deployment notes | ||
|
|
||
| [Amazon Web Services](https://aws.amazon.com/), [Elastic Fabric Adapter (EFA)](https://aws.amazon.com/hpc/efa/), [Supported instance types](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa.html#efa-instance-types), Provided by cloud, **Not supported** <!-- [Manual setup documentation](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa-start.html) --> |
There was a problem hiding this comment.
The deployment notes section of the table is specifically Charmed HPC's deployment correct? Clarifying the header will make the AWS 'not supported' statement clearer. Separately, we should decide if that statement should appear at all.
There was a problem hiding this comment.
Yep, it's specifically Charmed HPC - I've updated the header to "deployment notes for charmed hpc".
I've also commented out the AWS row and marked it with a TODO. On reflection, I don't think we should mention AWS until we've got more to say.
NucciTheBoss
added
feature
|
Looks good! We'll revisit adding AWS to the table when that work is closer to done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explanation for high-speed interconnects/RDMA implementations, including general definitions and how Charmed-HPC enables RDMA use.
Adds a reference table for cloud interconnects and their status in Charmed-HPC. At the moment, Azure is the only supported cloud out of the box but I've also included some AWS details following investigative work into their EFA solution.