Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge observability section into "Integrate with COS" howto #34

Merged

Conversation

NucciTheBoss
Copy link
Member

This PR merges the observability section into the "Integrate with COS" howto. It also adds the Manage section to the ToC tree.

Related issues

Things to consider

The Next Steps section in the howto might be a little clunky as they basically say "have fun!" but eventually I will have the section link to the Monitoring reference section which will outline the collected cluster metrics and provided Grafana dashboards.

…gnore

Had to add this link to because linkcheck could not find the `#deploy-in-isolation` anchor on the webpage

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss added docs This pull request makes a change to the documentation C-slurm Component: Slurm labels Feb 7, 2025
@NucciTheBoss NucciTheBoss requested a review from a team as a code owner February 7, 2025 21:31
@NucciTheBoss NucciTheBoss requested review from AshleyCliff and removed request for a team February 7, 2025 21:31
Signed-off-by: Jason C. Nucciarone <[email protected]>
Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few questions and suggestions about organization of sections and user use-cases.

@AshleyCliff
Copy link
Contributor

AshleyCliff commented Feb 11, 2025

A few comments and then we're good to go

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss
Copy link
Member Author

@AshleyCliff ready for round 2

@AshleyCliff
Copy link
Contributor

Looks good! Merging now.

@AshleyCliff AshleyCliff merged commit c1392f1 into charmed-hpc:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-slurm Component: Slurm docs This pull request makes a change to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate "Observability" section into one how-to titled "Integrate with COS"
2 participants