-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge observability section into "Integrate with COS" howto #34
Merged
AshleyCliff
merged 4 commits into
charmed-hpc:main
from
NucciTheBoss:nuccitheboss/fix/consolidate-cos
Feb 11, 2025
Merged
feat: merge observability section into "Integrate with COS" howto #34
AshleyCliff
merged 4 commits into
charmed-hpc:main
from
NucciTheBoss:nuccitheboss/fix/consolidate-cos
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
…gnore Had to add this link to because linkcheck could not find the `#deploy-in-isolation` anchor on the webpage Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
AshleyCliff
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few questions and suggestions about organization of sections and user use-cases.
A few comments and then we're good to go |
Signed-off-by: Jason C. Nucciarone <[email protected]>
@AshleyCliff ready for round 2 |
Looks good! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the observability section into the "Integrate with COS" howto. It also adds the
Manage
section to the ToC tree.Related issues
Things to consider
The
Next Steps
section in the howto might be a little clunky as they basically say "have fun!" but eventually I will have the section link to theMonitoring
reference section which will outline the collected cluster metrics and provided Grafana dashboards.