Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add justification for reboot timing on install #39

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

dsloanm
Copy link
Contributor

@dsloanm dsloanm commented Feb 17, 2025

Adds an Explanation for the 0-2 reboots a slurmd unit may perform as it's being installed. Essentially it reboots immediately if there's a kernel upgrade pending, reboots at the end of the hook if GPU drivers were installed, or doesn't reboot at all if neither of those cases occurred.

@dsloanm dsloanm requested a review from a team as a code owner February 17, 2025 15:42
@dsloanm dsloanm requested review from AshleyCliff and removed request for a team February 17, 2025 15:42
@dsloanm dsloanm added C-slurm Component: Slurm docs This pull request makes a change to the documentation labels Feb 19, 2025
Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good! If you could follow up on the TOC tree changes and a quick edit it'll be good to go

@dsloanm
Copy link
Contributor Author

dsloanm commented Feb 24, 2025

Thanks - latest commits move everything to a single .md file and include the suggested edit.

@dsloanm dsloanm requested a review from AshleyCliff February 24, 2025 10:45
@AshleyCliff
Copy link
Contributor

Looks good!

@AshleyCliff AshleyCliff merged commit 0bef4e7 into charmed-hpc:main Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-slurm Component: Slurm docs This pull request makes a change to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants