-
-
Notifications
You must be signed in to change notification settings - Fork 100
feat: protect the Date header #6877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Legacy Python test Lines 603 to 610 in adcc8a9
|
caf6eff
to
29d1d87
Compare
This has now broken the test added in c14f45a |
29d1d87
to
e533c2c
Compare
e533c2c
to
5663fff
Compare
68a4d43
to
154272e
Compare
7a65541
to
89df953
Compare
We do not try to delete resent messages anymore. Previously resent messages were distinguised by having duplicate Message-ID, but future Date, but now we need to download the message before we even see the Date. We now move the message to the destination folder but do not fetch it. It may not be a good idea to delete the duplicate in multi-device setups anyway, because the device which has a message may delete the duplicate of a message the other device missed. To avoid triggering IMAP move loop described in the comments we now only move the messages from INBOX and Spam folders.
154272e
to
10f3e09
Compare
We will have to use something less suspicious than unix epoch, GMX is unhappy: |
Closes #6878
Based on #6867
This depends an a fix #6669, so we may want to postpone merging this until more users have it.
We do not try to delete resent messages
anymore. Previously resent messages
were distinguised by having duplicate Message-ID,
but future Date, but now we need to download
the message before we even see the Date.
We now move the message to the destination folder
but do not fetch it.
It may not be a good idea to delete
the duplicate in multi-device setups anyway,
because the device which has a message
may delete the duplicate of a message
the other device missed.
To avoid triggering IMAP move loop
described in the comments
we now only move the messages
from INBOX and Spam folders.