Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor method to return empty if time is null #30

Merged
merged 4 commits into from
Apr 3, 2024
Merged

chore: refactor method to return empty if time is null #30

merged 4 commits into from
Apr 3, 2024

Conversation

vishnu-narayanan
Copy link
Member

@vishnu-narayanan vishnu-narayanan commented Feb 23, 2024 •
edited
Loading

  • Refactor convertSecondsToTimeUnit func to return empty_string rather than null if input is null

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/utils.cjs.production.min.js 2.55 KB (+0.08% 🔺)
dist/utils.esm.js 1.98 KB (+0.1% 🔺)

@muhsin-k muhsin-k merged commit 836dada into main Apr 3, 2024
7 of 8 checks passed
@muhsin-k muhsin-k deleted the feat/update_convertSecondsToTimeUnit branch April 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhsin-k muhsin-k muhsin-k approved these changes

Assignees

@vishnu-narayanan vishnu-narayanan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnu-narayanan @muhsin-k