Skip to content

fix(makefile): remove surplus dry-run and fixed typo in build-installer #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(makefile): remove surplus dry-run and fixed typo in build-installer #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c81eb6f
fix(makefile): remove surplus dry-run and fixed typo in build-installer
lgulliver Mar 31, 2025
8b906fd
Update package.json
lgulliver Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,6 @@ bundle-build: ## Build the bundle image.
bundle-push: ## Push the bundle image.
$(MAKE) docker-push IMG=$(BUNDLE_IMG)

.PHONY: dry-run
dry-run: manifests kustomize
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
mkdir -p ./dry-run
$(KUSTOMIZE) build config/default > dry-run/manifests.yaml

.PHONY: opm
OPM = ./bin/opm
opm: ## Download opm locally if necessary.
Expand Down Expand Up @@ -271,4 +265,4 @@ catalog-push: ## Push a catalog image.
build-installer: manifests generate kustomize ## Generate a consolidated YAML with CRDs and deployment.
mkdir -p dist
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
$(KUSTOMIZE) build config/default > dist/install.yam
$(KUSTOMIZE) build config/default > dist/install.yaml
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@
[
"@semantic-release/exec",
{
"prepareCmd": "VERSION=${nextRelease.version} make dry-run"
"prepareCmd": "VERSION=${nextRelease.version} make build-installer"
}
],
[
"@semantic-release/github",
{
"assets": [
{
"path": "dry-run/manifests.yaml",
"path": "dist/install.yaml",
"name": "install-${nextRelease.gitTag}.yaml",
"label": "install-${nextRelease.gitTag}.yaml"
}
Expand Down