Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard & maintenance window sample code filenames #1199

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

guolau
Copy link
Contributor

@guolau guolau commented Jan 27, 2025

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

Context: Dashboards and maintenance windows aren't usually included as Check dependencies. A file with the dashboard construct should include the .check.ts extension in its filename, otherwise the CLI won't pick it up.

@guolau guolau requested a review from ragog January 27, 2025 20:00
@guolau guolau requested a review from tnolet as a code owner January 27, 2025 20:00
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 2:16pm

Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch. @guolau let's merge it

@guolau guolau merged commit 6c90c5b into main Jan 28, 2025
6 checks passed
@guolau guolau deleted the guolau/fix-construct-sample-code-filenames branch January 28, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants