-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded on TCP check docs #1200
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
* **Databases** (e.g. `database.example.org:3306`): Verify that your database server is online and able to accept connections. | ||
* Databases (e.g. `database.example.org:3306`): Check that your database is online and accepting connections. To ensure that queries are processed as expected, you can additionally send a simple query like `SELECT 1` as part of the request and confirm the response matches what you’d expect via assertions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be able to send the SELECT 1
to the server, the customer would need to implement the MySQL line protocol within the payload. I don't think that's a feasible example at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be useful to add TCP subpages (similar to API):
- TCP Assertions, such as https://www.checklyhq.com/docs/api-checks/assertions/
- Response time limits, https://www.checklyhq.com/docs/api-checks/limits/
- Timeout and timing, https://www.checklyhq.com/docs/api-checks/timeouts-timing/
I can help with this if needed!
Great point, added as a to do here: https://www.notion.so/checkly/TCP-Check-Release-Checklist-149ec050b06e80a9b8f7caa96425bc61?pvs=4#15cec050b06e80aca58ec402af95abd1 - you're more than welcome to start drafting the sub pages if you have some spare time :) |
Sanity check on the new examples needed - I oriented towards customer use cases however relied on Google & ChatGPT to expand them. Would be great to get some feedback on whether these make sense from a more technical POV. Thank you!