Rough implementation of OpenID Connect. #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apognu
force-pushed
the
feat/poc/oidc-authentication
branch
3 times, most recently
from
fa7b163 to
3d717db
Compare
apognu
force-pushed
the
feat/poc/oidc-authentication
branch
from
3d717db to
3284e11
Compare
ChibiBlasphem
force-pushed
the
feat/poc/oidc-authentication
branch
2 times, most recently
from
09ea524 to
46d0611
Compare
ChibiBlasphem
force-pushed
the
feat/poc/oidc-authentication
branch
5 times, most recently
from
09d94d6 to
8829924
Compare
ChibiBlasphem
force-pushed
the
feat/poc/oidc-authentication
branch
from
8829924 to
353b542
Compare
Pascal-Delange
approved these changes
Oct 21, 2025
| const response = await basicFetch(input, { ...init, headers }); | ||
|
|
||
| if (response.status === 401) { | ||
| // TODO: here, we use the new tokens for the current request, but it is |
There was a problem hiding this comment.
comment still relevant ?
| failureRedirect: getRoute('/sign-in'), | ||
| }); | ||
|
|
||
| const res = await next({ context: { authInfo } }); |
There was a problem hiding this comment.
just testing my understanding of your middleware function: should we not call next with the received context to which we add authInfo ?
There was a problem hiding this comment.
The merge on the context sent to next and the previous one is automatically merge. You only need to send the new context properties you want to set.
ChibiBlasphem
force-pushed
the
feat/poc/oidc-authentication
branch
3 times, most recently
from
f5bed9e to
3b5984d
Compare
ChibiBlasphem
force-pushed
the
feat/poc/oidc-authentication
branch
from
3b5984d to
f813572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
See checkmarble/marble-backend#1204.
This is not mergeable, for several reasons, it will need an actual frontend engineer to clean up, handle edge cases, and support refresh.
Also, note that there is no error handling. If the IDP returns an error, it will be displayed as plain text in the browser. :D