Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logger calls from to_prepare #15

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Remove logger calls from to_prepare #15

merged 2 commits into from
Jul 3, 2024

Conversation

julik
Copy link
Contributor

@julik julik commented Jul 3, 2024 •
edited
Loading

We do not test to_prepare in our test flow, as it turns out - and we were still assigning the value

julik added 2 commits July 3, 2024 13:47
@julik
Remove logger calls from to_prepare
da57740 
We do not test to_prepare in our test flow, as it turns out - and we were still assigning the value
@julik
Bump version and changelog
e515657
@julik julik changed the title Fix logger level error Remove logger calls from to_prepare Jul 3, 2024
@svanhesteren svanhesteren self-requested a review July 3, 2024 11:49
svanhesteren
svanhesteren approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@svanhesteren svanhesteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julik julik merged commit 4a760a5 into main Jul 3, 2024
2 checks passed
@julik julik deleted the fix-logger-level-error branch July 3, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanhesteren svanhesteren svanhesteren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julik @svanhesteren