Relax ffi dependency to allow 1.17.1 and up #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-relax-ffi
branch
3 times, most recently
from
3b5ad3d to
304d0a0
Compare
stanhu
changed the title
chef#81 limited the ffi version to <= 1.17.0, but it's not actually broken as explained in ffi/ffi#1139 (comment). The issues Chef are having are to issues with precompiled native Gems on Omnibus Chef builds. Signed-off-by: Stan Hu <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81 limited the ffi version to <= 1.17.0, but it's not actually broken as explained in ffi/ffi#1139 (comment).
The issues Chef are having are specific to precompiled native Gems on Omnibus Chef builds.
Description
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.