Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no previous tag when using get cmd #148

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix no previous tag when using get cmd #148

merged 1 commit into from
May 3, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented May 3, 2024

Fixes #144

@chelnak
Copy link
Owner

chelnak commented May 3, 2024

@h0tw1r3 thank you for the contribution!

I've been holding off on a release while I investigate #145 however it's taking a little longer thank I expected to finish.

Let's get this merged and I can cut a release today.

@chelnak chelnak merged commit 5392d1e into chelnak:main May 3, 2024
1 check passed
@chelnak chelnak added the bug Something isn't working label May 3, 2024
@h0tw1r3 h0tw1r3 deleted the fix/144 branch May 3, 2024 16:27
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 3, 2024

@chelnak Took another look this morning, looks like there's a panic on get --latest when there's only one entry in the changelog. Working on a fix.

@chelnak
Copy link
Owner

chelnak commented May 3, 2024

Oh nice, is it there when you pull the latest release? I fixed a panic in the parser.. maybe it's related?

@h0tw1r3 h0tw1r3 mentioned this pull request May 3, 2024
Merged
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 3, 2024

Yes, pretty obvious bug. Should have been sleeping instead of coding 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Changelog in GitHub Release too broad
2 participants
@h0tw1r3 @chelnak