Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Complete and Error Characters #82

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

flippedcracker
Copy link

This allows users to set custom Complete and Error Characters, as seen in yacspin.

Copy link
Owner

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for the contribution.

manager.go Outdated
}
}

// WithErrorCharacter sets the error character
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this comment is missing a full stop at the end.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the comment.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@chelnak chelnak merged commit 60dc024 into chelnak:main Jan 24, 2025
1 check passed
@chelnak chelnak added the enhancement New feature or request label Jan 25, 2025
@chelnak
Copy link
Owner

chelnak commented Jan 25, 2025

I've just released v.0.6.0 with this change. Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants