fnc 0.18 (new formula)#2676
Open
chenrui333 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Homebrew formula for fnc version 0.18, an interactive text-based user interface for Fossil SCM.
- Introduces fnc 0.18 formula with basic build and test configuration
- Uses make-based build system with PREFIX installation
- Includes version check and error message validation in tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| license "ISC" | ||
|
|
||
| def install | ||
| system "make" |
There was a problem hiding this comment.
[nitpick] The separate system "make" call can be combined with the install step. Most formulas in this repository that use make-based builds (e.g., fat.rb, imgcat.rb) combine these into a single call: system "make", "install", "PREFIX=#{prefix}". This reduces redundancy and follows the pattern where make will handle dependencies automatically.
Suggested change
| system "make" |
chenrui333
added
in progress
Signed-off-by: Rui Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.