[email protected]: use zlib-ng-compat on Linux#4986
Draft
chenrui333 wants to merge 1 commit intomainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the [email protected] Homebrew formula to use zlib-ng-compat specifically on Linux instead of the previous uses_from_macos "zlib" behavior.
Changes:
- Removes
uses_from_macos "zlib". - Adds a Linux-only dependency on
zlib-ng-compat.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses_from_macos "ncurses" | ||
| uses_from_macos "zlib" | ||
|
|
||
| on_linux do |
There was a problem hiding this comment.
Depending on zlib-ng-compat (instead of the more typical zlib) is a non-obvious choice in a formula. Consider adding a short inline comment explaining why Zig 0.12 specifically needs zlib-ng-compat on Linux (and ideally link to the relevant issue/PR). This will help future maintainers understand why this dependency is OS-conditional and why the standard zlib was not used.
Suggested change
| on_linux do | |
| on_linux do | |
| # Use zlib-ng-compat on Linux to match Zig 0.12's upstream zlib-ng usage. | |
| # See discussion in https://github.com/Homebrew/homebrew-core/pull/141453. |
chenrui333
force-pushed
the
zlibng-zig-0.12
branch
2 times, most recently
from
0dcb25f to
3c01d49
Compare
chenrui333
added
the
CI-no-fail-fast
chenrui333
force-pushed
the
zlibng-zig-0.12
branch
from
3c01d49 to
ad34841
Compare
Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
zlibng-zig-0.12
branch
from
ad34841 to
7d9aa8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style and audit pass locally on macOS.
Replaces
uses_from_macos \"zlib\"with a Linux-onlydepends_on \"zlib-ng-compat\"block.