-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 이미지 추가/삭제와 관련된 앨범 용량 추가/감소 로직 추가 #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6835459
refactor: 이미지 생성 로직에 용량 관련 사항 추가
yongjun0511 f2e3e87
refactor: 업로드 실패 파일 presignedUrl 기반 삭제 제거
yongjun0511 dc57e3d
refactor: presignedUrl 발급 API에서 imageId를 반환
yongjun0511 e85f5b2
refactor: presignedUrl 발급시 ID 반환하도록 수정
yongjun0511 83433de
fix: 테스트 오류 해결
yongjun0511 9bbf1e7
refactor: 앨범 용량 감소 로직 추가
yongjun0511 0cff0f7
refactor: dto 명명 변경
yongjun0511 905def4
refactor: 미사용 validation 삭제
yongjun0511 32e2a3d
refactor: 검증 순서 수정
yongjun0511 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 0 additions & 10 deletions
10
...i/src/main/java/org/cherrypic/domain/image/dto/request/UploadFailedFileDeleteRequest.java
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
...ypic-api/src/main/java/org/cherrypic/domain/image/dto/response/PresignedUrlsResponse.java
This file was deleted.
Oops, something went wrong.
19 changes: 19 additions & 0 deletions
19
...pic-api/src/main/java/org/cherrypic/domain/image/dto/response/UploadFileListResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package org.cherrypic.domain.image.dto.response; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import java.util.List; | ||
|
|
||
| public record UploadFileListResponse( | ||
| @Schema(description = "업로드된 파일들의 정보 리스트") List<Payload> payloads) { | ||
| public static UploadFileListResponse of(List<Payload> payloads) { | ||
| return new UploadFileListResponse(payloads); | ||
| } | ||
|
|
||
| public record Payload( | ||
| @Schema(description = "생성된 이미지의 ID") Long imageId, | ||
| @Schema(description = "생성된 Presigned Url") String presignedUrl) { | ||
| public static Payload of(Long imageId, String presignedUrl) { | ||
| return new Payload(imageId, presignedUrl); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
용량 계산 전에 앨범 참가자 검증을 먼저 해도 괜찮을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다!