feat: 임시 앨범 이미지 업로드 PresignedURL 발급 & 임시 앨범 이미지 삭제 API 구현 #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongjun0511
changed the title
ht3064
reviewed
Sep 12, 2025
...pi/src/main/java/org/cherrypic/domain/tempalbum/repository/TempAlbumImageRepositoryImpl.java
Outdated
Show resolved
Hide resolved
ht3064
reviewed
Sep 12, 2025
| CREATE_OVER_LIMIT(400, "임시 앨범은 5개 이상으로 만들 수 없습니다."), | ||
| TEMP_ALBUM_CAPACITY_EXCEEDED(400, "임시 앨범의 용량을 초과했습니다."), | ||
| IMAGES_NOT_IN_TEMP_ALBUM(400, "임시 앨범에 속해 있지 않은 이미지가 포함되어 있습니다."), | ||
| DUPLICATE_HASHES(400, "중복되는 md5 해시값이 존재합니다."), |
Collaborator
There was a problem hiding this comment.
DUPLICATE_HASHES 에러 코드가 이미 ImageErrorCode에 정의되어 있던데 재활용하는게 더 좋아보여요!
Collaborator
Author
There was a problem hiding this comment.
검증 메서드와 엔티티 자체도 달라서 분리했습니다!
ht3064
reviewed
Sep 12, 2025
cherrypic-api/src/main/java/org/cherrypic/domain/image/service/ImageServiceImpl.java
Outdated
Show resolved
Hide resolved
ht3064
reviewed
Sep 12, 2025
cherrypic-api/src/main/java/org/cherrypic/domain/image/service/ImageServiceImpl.java
Show resolved
Hide resolved
yongjun0511
force-pushed
the
feat/204-temp-album-image-upload-delete
branch
from
241aa03 to
9df1ac3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📚 참고사항