Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation improvements #174

Merged
merged 4 commits into from
Apr 4, 2016
Merged

Installation improvements #174

merged 4 commits into from
Apr 4, 2016

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Apr 4, 2016

It would be best if we provided lower resolutions icons, but my DE (cinnamon) can do the downsize (256 to lower res) perfectly.
pic

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.382% when pulling 1eb5911 on Chocobo1:install into 85611b8 on chewing:master.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Apr 4, 2016

@jserv @czchen
IMO, the version string should bump after merging this, because chewing-editor.desktop were installed to the wrong dir before this fix.

@czchen
Copy link
Member

czchen commented Apr 4, 2016

@Chocobo1

I guess you mean changing version to 0.1.0 instead of 0.0.4 ? I think this can be considered as bugfix (fix typo in chewing-editor.desktop install path), as well as new feature (since chewing-editor.desktop never works before this commit, we can consider it as a new feature). So both 0.1.0 and 0.0.4 are fine with me for the next release.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Apr 4, 2016

I guess you mean changing version to 0.1.0 instead of 0.0.4 ?

I was thinking 0.0.4, but 0.1.0 is fine for me too. Your decision :)

Speaking of this, I always think this program is somewhat stable & functional, personally I would give it a 1.0 version (in sense of a first stable release).

@czchen
Copy link
Member

czchen commented Apr 4, 2016

I think we can release 1.0.0 once the #2 and #108 are fixed.

@czchen czchen merged commit 0ab458f into chewing:master Apr 4, 2016
@Chocobo1 Chocobo1 deleted the install branch April 4, 2016 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants